Add missing $maxsize option to Logrotate::Conf #90
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @achermes, thanks for the PR. We're happy to assist you. I recommend the following to install the needed gems: If this doesn't work for you or if you have more questions, please ping us in the #voxpupuli IRC channel on freenode,we're happy to help out. |
|
Ok, after much wrangling with ruby I was able to install the dependencies and run |
juniorsysadmin
approved these changes
Dec 2, 2017
|
@achermes Are you able to add tests in the |
|
It'll be a while before I have time to engage with this so not in the short term. I'll point out that this parameter is already referenced in the code (in the templates) :) |
juniorsysadmin
approved these changes
Dec 7, 2017
|
Fixes #49 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR re-adds the missing
$maxsizeoption toLogrotate::Conf. This was regressed during a refactor - see #49.I have only added this line and not tested this as I was not able to get set up for testing this (I ran into gem dependency conflicts).