Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use default systemd timer for EL9 logrotate #216

Merged
merged 2 commits into from
Dec 5, 2023
Merged

Use default systemd timer for EL9 logrotate #216

merged 2 commits into from
Dec 5, 2023

Conversation

treydock
Copy link

@treydock treydock commented Dec 5, 2023

Fixes #214

@treydock treydock added the enhancement New feature or request label Dec 5, 2023
Copy link
Member

@kenyon kenyon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The Debian and Ubuntu packages also use systemd timers.

@treydock
Copy link
Author

treydock commented Dec 5, 2023

The Debian and Ubuntu packages also use systemd timers.

Ya, I figured update the Hiera data once those OSes are officially listed in metadata.json.

@treydock treydock merged commit 5e4fde1 into master Dec 5, 2023
14 checks passed
@treydock treydock deleted the el9-timer branch December 5, 2023 20:57
@treydock treydock added bug Something isn't working enhancement New feature or request and removed enhancement New feature or request bug Something isn't working labels Dec 5, 2023
traylenator added a commit to traylenator/puppet-logrotate that referenced this pull request Feb 19, 2024
When EL9 switched to using systemd (quite correctly ) in voxpupuli#216 support
for a special directory for hourly logrotations was removed.

Add that functionality back with a new unit and timer
* `logrotate-hourly.service`
* `logrotate-hourly.timer`

While this could be achieved by reducing the period of existing timer
to hourly I presume the motivation for this was to avoid processing
all logrotate directives every hour.
traylenator added a commit to traylenator/puppet-logrotate that referenced this pull request Feb 19, 2024
When EL9 switched to using systemd (quite correctly ) in voxpupuli#216 support
for a special directory for hourly logrotations was removed.

Add that functionality back with a new unit and timer
* `logrotate-hourly.service`
* `logrotate-hourly.timer`

While this could be achieved by reducing the period of existing timer
to hourly I presume the motivation for this was to avoid processing
all logrotate directives every hour.
traylenator added a commit to traylenator/puppet-logrotate that referenced this pull request Feb 19, 2024
When EL9 switched to using systemd (quite correctly ) in voxpupuli#216 support
for a special directory for hourly logrotations was removed.

Add that functionality back with a new unit and timer
* `logrotate-hourly.service`
* `logrotate-hourly.timer`

While this could be achieved by reducing the period of existing timer
to hourly I presume the motivation for this was to avoid processing
all logrotate directives every hour.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for systemd-timer
2 participants