forked from rodjek/puppet-logrotate
-
-
Notifications
You must be signed in to change notification settings - Fork 92
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use default systemd timer for EL9 logrotate #216
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kenyon
approved these changes
Dec 5, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The Debian and Ubuntu packages also use systemd timers.
Ya, I figured update the Hiera data once those OSes are officially listed in metadata.json. |
treydock
added
bug
Something isn't working
enhancement
New feature or request
and removed
enhancement
New feature or request
bug
Something isn't working
labels
Dec 5, 2023
traylenator
added a commit
to traylenator/puppet-logrotate
that referenced
this pull request
Feb 19, 2024
When EL9 switched to using systemd (quite correctly ) in voxpupuli#216 support for a special directory for hourly logrotations was removed. Add that functionality back with a new unit and timer * `logrotate-hourly.service` * `logrotate-hourly.timer` While this could be achieved by reducing the period of existing timer to hourly I presume the motivation for this was to avoid processing all logrotate directives every hour.
traylenator
added a commit
to traylenator/puppet-logrotate
that referenced
this pull request
Feb 19, 2024
When EL9 switched to using systemd (quite correctly ) in voxpupuli#216 support for a special directory for hourly logrotations was removed. Add that functionality back with a new unit and timer * `logrotate-hourly.service` * `logrotate-hourly.timer` While this could be achieved by reducing the period of existing timer to hourly I presume the motivation for this was to avoid processing all logrotate directives every hour.
traylenator
added a commit
to traylenator/puppet-logrotate
that referenced
this pull request
Feb 19, 2024
When EL9 switched to using systemd (quite correctly ) in voxpupuli#216 support for a special directory for hourly logrotations was removed. Add that functionality back with a new unit and timer * `logrotate-hourly.service` * `logrotate-hourly.timer` While this could be achieved by reducing the period of existing timer to hourly I presume the motivation for this was to avoid processing all logrotate directives every hour.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #214