Update defaults to match RHEL8/9

[jcpunk]

Pull Request (PR) description

RHEL8 and later use a slightly different default for wtmp

This Pull Request (PR) fixes the following issues

N/A

[bastelfreak]

we should really port this to rspec-puppet-facts soonish

[bastelfreak]

Thanks for the PR. Can you please add CentOS 8/9 to metadata.json?

[jcpunk]

Done

[bastelfreak]

can you please take a look at the failing tests?

[jcpunk]

I have no idea why these tests are failing.... there is something amiss with the OS detection code but that is beyond me....

[vchepkov]

Seems complicated, how about

$wtmp_missingok = versioncmp($facts['os']['release']['major'],'7')) <= 0 ? {
   true => false,
  default => true,
}
and no need to create duplicate resource definition?

[jcpunk]

Updated with the suggested form.

[jcpunk]

I honestly don't see how these changes are suddenly making the self tests fail the group ownership or file ensures....

[vchepkov]

LGTM

[jcpunk]

Rebased following latest module sync

[jcpunk]

The failures I'm showing are part of the existing failure set.

[ekohl]

Isn't this equivalent?

Suggested change

	$wtmp_missingok = versioncmp($facts['os']['release']['major'],'7') <= 0 ? {
	true => false,
	default => true,
	}
	$wtmp_missingok = versioncmp($facts['os']['release']['major'],'8') >= 0

[jcpunk]

done

[ekohl]

Rather than duplicating it, thoughts on the following (where I didn't bother with correctly indenting):

Suggested change

	if facts[:operatingsystemmajrelease].to_i <= 7
	it {
	is_expected.to contain_logrotate__rule('wtmp').with(
	'path' => '/var/log/wtmp',
	'create_mode' => '0664',
	'missingok' => false,
	'minsize' => '1M',
	'create' => true,
	'create_owner' => 'root',
	'create_group' => 'utmp',
	'rotate' => 1,
	'rotate_every' => 'monthly'
	)
	}
	else
	it {
	is_expected.to contain_logrotate__rule('wtmp').with(
	'path' => '/var/log/wtmp',
	'create_mode' => '0664',
	'missingok' => true,
	'minsize' => '1M',
	'create' => true,
	'create_owner' => 'root',
	'create_group' => 'utmp',
	'rotate' => 1,
	'rotate_every' => 'monthly'
	)
	}
	end
	it do
	is_expected.to contain_logrotate__rule('wtmp').with(
	'path' => '/var/log/wtmp',
	'create_mode' => '0664',
	'missingok' => facts[:operatingsystemmajrelease].to_i >= 8,
	'minsize' => '1M',
	'create' => true,
	'create_owner' => 'root',
	'create_group' => 'utmp',
	'rotate' => 1,
	'rotate_every' => 'monthly'
	)
	end

[jcpunk]

done