Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add official puppet 4 support #17

Merged
merged 2 commits into from
Feb 25, 2016
Merged

Conversation

mmckinst
Copy link

  • add official puppet 4 support
  • drop puppet 2.7 support
  • simplify the travis testing matrix- if there's no actual ruby code in the module, then there's no reason to test the module against all the different versions of ruby. just test against the versions of ruby officially supported by puppet:
  • remove Gemfile.lock and add to .gitignore

@mmckinst
Copy link
Author

some of this overlaps with pull request #16 but if the current code works with puppet 4.x, it would be great to see this merged and mentioned on puppetforge

@robinbowes
Copy link

Can you fix up the tests and I'll take a more detailed look at this?

@mmckinst mmckinst force-pushed the puppet4 branch 3 times, most recently from fb2cf93 to ae2df73 Compare February 24, 2016 23:01
@mmckinst
Copy link
Author

@robinbowes tests now passing. I realized there's ruby code in the ruby templates so if you want to be on the super safe side, you might want to include all the versions of ruby like before

@robinbowes
Copy link

Yeah, can you put those back, except the 2.7.0 tests, and I'll merge this.

Have you done much testing with 4.x?

@mmckinst mmckinst force-pushed the puppet4 branch 4 times, most recently from bd11dd6 to 1905526 Compare February 25, 2016 01:17
@mmckinst
Copy link
Author

there we go, finally passing. I haven't done extensive testing with this module on puppet 4 yet, but will be doing tomorrow.

@robinbowes robinbowes self-assigned this Feb 25, 2016
robinbowes added a commit that referenced this pull request Feb 25, 2016
add official puppet 4 support
@robinbowes robinbowes merged commit 1a379a9 into voxpupuli:master Feb 25, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants