Allow cron to always mail its output. #124
Conversation
I was used to the fact that redhat always mails its output. I enabled the managed_cron bool, and added the --verbose startup argument (for debugging) and all mail went away...
|
I'd like some help on how to interpret the test-errors... I don't understand. |
|
The current errors you're seeing are a result of a bug with our travis config. It will be fixed as soon as we update modulesync. Once that is merged, you can rebase to re-run CI. |
I was used to the fact that redhat always mails its output. I enabled the managed_cron bool, and added the --verbose startup argument (for debugging) and all mail went away...
manifests/init.pp
Outdated
| @@ -22,7 +22,8 @@ | |||
| Stdlib::Filemode $rules_configdir_mode = $logrotate::params::rules_configdir_mode, | |||
| String $root_user = $logrotate::params::root_user, | |||
| String $root_group = $logrotate::params::root_group, | |||
| Array[String] $logrotate_args = [] | |||
| Array[String] $logrotate_args = [], | |||
There was a problem hiding this comment.
Can you please enforce a minimal string length like this:
Array[String[1]]There was a problem hiding this comment.
Yes, I agree that is better. However, it belongs to pull request 80. I will fix it there.
https://github.com/Heidistein/puppet-logrotate/tree/pr80fix
There was a problem hiding this comment.
Fixed in PR #127
I added only a trailing comma here, this was unrelated to this change.
bastelfreak
added
backwards-incompatible
needs-work
|
Hi @Heidistein. thanks for the PR. Can you take a look at the inline comment I made? |
bastelfreak
added
needs-rebase
and removed
needs-work
|
Hi, can you please rebase? |
|
Rebase done. |
| @@ -78,6 +78,18 @@ | |||
| with_content(%r{(\/usr\/local\/sbin\/logrotate -s \/var\/lib\/logrotate\/logrotate.status -m \/usr\/sbin\/mailer \/usr\/local\/etc\/logrotate.conf 2>&1)}) | |||
| } | |||
| end | |||
|
|
|||
| context 'With additional arguments' do | |||
| let(:pre_condition) { 'class {"::logrotate": cron_always_output => true}' } | |||
There was a problem hiding this comment.
FYI the :: aren't needed in front of logrotate
|
Thanks! |
I was used to the fact that redhat always mails its output. I enabled
the managed_cron bool, and added the --verbose startup argument (for
debugging) and all mail went away...
Pull Request (PR) description
This Pull Request (PR) fixes the following issues