forked from rodjek/puppet-logrotate
-
-
Notifications
You must be signed in to change notification settings - Fork 92
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Logrotate rule ERB template should not take variables from the scope object #37
Comments
To reproduce, add the following test to the
|
imriz
added a commit
to myheritage/puppet-logrotate
that referenced
this issue
Aug 9, 2016
…ables from the scope object
imriz
added a commit
to myheritage/puppet-logrotate
that referenced
this issue
Aug 9, 2016
…ables from the scope object
imriz
added a commit
to myheritage/puppet-logrotate
that referenced
this issue
Aug 9, 2016
…ables from the scope object
imriz
added a commit
to myheritage/puppet-logrotate
that referenced
this issue
Aug 9, 2016
…ables from the scope object
imriz
added a commit
to myheritage/puppet-logrotate
that referenced
this issue
Aug 9, 2016
…ables from the scope object
imriz
added a commit
to myheritage/puppet-logrotate
that referenced
this issue
Aug 9, 2016
…ables from the scope object
imriz
added a commit
to myheritage/puppet-logrotate
that referenced
this issue
Aug 9, 2016
…ables from the scope object
imriz
added a commit
to myheritage/puppet-logrotate
that referenced
this issue
Aug 9, 2016
…ables from the scope object
This is likely the root cause of issue #13 |
@natemccurdy , definitely. Have the same issue. Any chance on #38 merged? |
bastelfreak
added a commit
that referenced
this issue
May 25, 2017
Fixes #37 - Logrotate rule ERB template should not take variables from the scope object
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
It should use
has_variable?
andinstance_variable_get
methods.The reason is that the scope object has variables from any scope, and this might add variable values from other
logrotate::rule
instances, depending on declaration/parsing order.This is probably the same root cause for #22
The text was updated successfully, but these errors were encountered: