Added custom_plugin param in certonly to disable use of '-a' flag. #84
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bastelfreak
reviewed
Feb 12, 2017
manifests/certonly.pp
Outdated
| @@ -32,6 +34,7 @@ | |||
| # | |||
| define letsencrypt::certonly ( | |||
| $domains = [$title], | |||
| $custom_plugin = false, | |||
There was a problem hiding this comment.
can you use the new Pupept 4 Datatype Boolean instead of the validate_re down below?
|
Thanks @Lavaburn for writing this PR. It fixes the problem I was just looking into :). I hope it can be merged soon ;-) |
|
Hi @Lavaburn, could you please rebase against latest master to fix the merge conflict? |
Lavaburn
force-pushed
the
pr_custom_plugin
branch
from
cae9c25 to
6cb5924
Compare
|
thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I need to validate my domain using DNS, which I found is possible with external_auth plugin.
Using this plugin with certbot however requires '-a ' flag to be removed from the certbot command.
This fix introduces a new parameter and does not break any existing code. As an extra, I allowed nginx as plugin, which is also supported now in certbot.