Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

install and use the certbot nginx plugin #267

Merged
merged 2 commits into from
Jan 11, 2022
Merged

Conversation

nod0n
Copy link
Contributor

@nod0n nod0n commented Dec 14, 2021

Pull Request (PR) description

A try to get the Nginx authenticator in this module. I started from #197, tried to throw out what was not related to the nginx plugin and tried to simplify where possible.

This Pull Request (PR) fixes the following issues

The nginx certbot plugin has currently to be installed outside of this module.

data/os/CentOS/7.yaml Outdated Show resolved Hide resolved
@nod0n nod0n force-pushed the nginx branch 10 times, most recently from e03243b to 7761142 Compare December 15, 2021 07:13
@nod0n nod0n marked this pull request as ready for review December 15, 2021 10:54
README.md Outdated Show resolved Hide resolved
spec/classes/plugin/nginx_spec.rb Outdated Show resolved Hide resolved
spec/classes/plugin/nginx_spec.rb Outdated Show resolved Hide resolved
spec/classes/plugin/nginx_spec.rb Outdated Show resolved Hide resolved
@nod0n nod0n force-pushed the nginx branch 5 times, most recently from 1bd5bd1 to 1cf5087 Compare December 15, 2021 14:40
Copy link
Member

@ekohl ekohl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apologies for the scope creep. I hope you appreciate the learning part of it.

manifests/certonly.pp Outdated Show resolved Hide resolved
manifests/plugin/nginx.pp Outdated Show resolved Hide resolved
manifests/plugin/nginx.pp Outdated Show resolved Hide resolved
spec/classes/plugin/nginx_spec.rb Outdated Show resolved Hide resolved
@nod0n nod0n force-pushed the nginx branch 4 times, most recently from cd2fbb7 to f34f91e Compare December 15, 2021 15:41
Copy link
Member

@ekohl ekohl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I restarted the tests since the failures looked intermittent.

@bastelfreak bastelfreak added the enhancement New feature or request label Jan 11, 2022
@bastelfreak bastelfreak merged commit b1f9d22 into voxpupuli:master Jan 11, 2022
@nod0n nod0n mentioned this pull request Jan 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants