-
Notifications
You must be signed in to change notification settings - Fork 136
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
install and use the certbot nginx plugin #267
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bastelfreak
reviewed
Dec 14, 2021
nod0n
force-pushed
the
nginx
branch
10 times, most recently
from
December 15, 2021 07:13
e03243b
to
7761142
Compare
bastelfreak
approved these changes
Dec 15, 2021
ekohl
reviewed
Dec 15, 2021
nod0n
force-pushed
the
nginx
branch
5 times, most recently
from
December 15, 2021 14:40
1bd5bd1
to
1cf5087
Compare
ekohl
reviewed
Dec 15, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Apologies for the scope creep. I hope you appreciate the learning part of it.
nod0n
force-pushed
the
nginx
branch
4 times, most recently
from
December 15, 2021 15:41
cd2fbb7
to
f34f91e
Compare
ekohl
approved these changes
Dec 21, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I restarted the tests since the failures looked intermittent.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request (PR) description
A try to get the Nginx authenticator in this module. I started from #197, tried to throw out what was not related to the nginx plugin and tried to simplify where possible.
This Pull Request (PR) fixes the following issues
The nginx certbot plugin has currently to be installed outside of this module.