Certonly: Refactor manage_cron to ensure_cron with appropriate data type

[craigwatson]

Pull Request (PR) description

Ensures cron is removed when manage_cron is false.

This Pull Request (PR) fixes the following issues

Fixes #139

[ekohl]

Looks good. Do we also want to ensure the renew file so it's only present when managing the cron?

[craigwatson]

@ekohl fair point 👍

[Dan33l]

I strongly disagree with the current implementation.

With puppet language, we describe the state we want. With manage_cron to false, i understand we do not want a cron management. And what is doing this setting ? It manage the cron to ensure it is absent.

IMO it should be clearer to rename manage_cron to ensure_cron with data type Enum['present','absent'].

[ekohl]

That's a very fair point and I do agree ensure_cron is much better.

[craigwatson]

@Dan33l and @ekohl I agree, thanks for raising - I've updated the PR to use $ensure_cron with the correct data type. As this is a backwards-imcompatible change, how would you like to handle deprecation of manage_cron?

[Dan33l]

@craigwatson Thank you.

[baurmatt]

Ööööhm so as this is a breaking change, do we release 4.0.0?

[bastelfreak]

Yes, the next release will be a major one.