Allow wildcard domains for certonly::domains #142
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… wildcard domains Added *.example.com to spec test
juniorsysadmin
approved these changes
Oct 20, 2018
|
@Wimmesberger The e-mail address for your commit does not match your GitHub account. It is preferable for Voxpupuli Pull Requests that it does. |
|
@Wimmesberger Thank you. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request (PR) description
The current datatype
Array[Stdlib::Host]forcertonly::domainsis too strict and does not allow for domains containing asterisks to generate wildcard certificates.My proposed change would be:
Array[Stdlib::Host]->Array[String[1]]Feel free to implement some other validation pattern in case
Array[String[1]]is too loose.Bonus: Added a case of
*.example.comto spec test (excluding webroot plugin since you need the DNS-01 challenge)