Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate letsencrypt::config::ini helper to native Puppet 4 #136

Merged
merged 1 commit into from
Sep 3, 2018
Merged

Migrate letsencrypt::config::ini helper to native Puppet 4 #136

merged 1 commit into from
Sep 3, 2018

Conversation

baurmatt
Copy link
Contributor

@baurmatt baurmatt commented Sep 3, 2018

Pull Request (PR) description

This PR migrates the letsencrypt::config::ini define type into native Puppet 4 code.

This Pull Request (PR) fixes the following issues

--

ekohl
ekohl approved these changes Sep 3, 2018
View reviewed changes
Copy link
Member

@ekohl ekohl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Given it's a private class it's not a breaking change.

@ekohl ekohl added the enhancement New feature or request label Sep 3, 2018
@bastelfreak
Copy link
Member

Thanks for the PR @baurmatt !

@bastelfreak bastelfreak merged commit b284261 into voxpupuli:master Sep 3, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ekohl ekohl ekohl approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@baurmatt @bastelfreak @ekohl