Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #81 added -n flag to certbot to run in unattended mode. #112

Merged
merged 2 commits into from
Feb 28, 2018

Conversation

K0HAX
Copy link
Contributor

@K0HAX K0HAX commented Jan 29, 2018

No description provided.

@@ -53,9 +53,9 @@
}

if ($custom_plugin) {
$command_start = "${letsencrypt_command} --text --agree-tos certonly "
$command_start = "${letsencrypt_command} --text --agree-tos -n certonly "
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder if using "--non-interactive" instead of "-n" might be more self-documenting?

Copy link
Contributor

@siebrand siebrand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comment about readability.

@bastelfreak
Copy link
Member

Hi @K0HAX , thanks for the PR! Can you please switch to --non-interactive?

@bastelfreak bastelfreak added enhancement New feature or request needs-work not ready to merge just yet labels Feb 28, 2018
@bastelfreak
Copy link
Member

Fixes #81

@bastelfreak bastelfreak merged commit 3c7266a into voxpupuli:master Feb 28, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request needs-work not ready to merge just yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants