Merge pull request #1 from ghoneycutt/asdf

A collection of commits working toward getting this to v1

.gitignore

@@ -1,6 +1,35 @@
 .*.sw?
-pkg
-spec/fixtures
 .rspec_system
 .vagrant
 vendor
+# Default .gitignore for Ruby
+*.gem
+*.rbc
+.bundle
+.config
+coverage
+InstalledFiles
+lib/bundler/man
+pkg
+rdoc
+spec/reports
+test/tmp
+test/version_tmp
+tmp
+Gemfile.lock
+
+# YARD artifacts
+.yardoc
+_yardoc
+doc/
+
+# Vim
+*.swp
+
+# OS X
+.DS_Store
+
+# Puppet
+coverage/
+spec/fixtures/modules/*
+spec/fixtures/manifests/*

.rubocop.yml

@@ -0,0 +1,53 @@
+---
+AllCops:
+#  DisplayCopNames: true
+  DisplayStyleGuide: true
+  Exclude:
+    - 'vendor/**/*'
+    - 'pkg/**/*'
+    - 'spec/fixtures/**/*'
+    - '**/Rakefile'
+
+# Cop's to ignore
+
+# With this enabled it suggests a change that will break the Gemfile
+Lint/AssignmentInCondition:
+  Enabled: false
+
+Metrics/LineLength:
+  Enabled: false
+
+# This is a good idea, but does not line up the rest of the lines making it
+# harder to read
+Style/IndentHash:
+  Enabled: false
+
+Style/Next:
+  Enabled: false
+
+# If enabled, this cop makes it harder to understand the logic
+Style/NonNilCheck:
+  Enabled: false
+
+Style/TrailingComma:
+  Enabled: false
+
+# If enabled, this cop does not like the accessor method to start with 'get_',
+# with is a common pattern in the Puppet community.
+Style/AccessorMethodName:
+  Enabled: false
+
+# This is a common pattern in the Puppet community.
+Style/ClassAndModuleChildren:
+  Enabled: false
+
+# This is a common pattern in the Puppet community.
+Style/Documentation:
+  Enabled: false
+
+# Cop's that require ruby >= 1.9
+Style/HashSyntax:
+  Enabled: false
+
+Style/BracesAroundHashParameters:
+  Enabled: false

.travis.yml

@@ -13,3 +13,5 @@ env:
   - PUPPET_VERSION="~> 4.1.0"
   - PUPPET_VERSION="~> 4.2.0"
   - PUPPET_VERSION="~> 4.3.0"
+  - PUPPET_VERSION="~> 4"
+  - PUPPET_VERSION="~> 4" STRICT_VARIABLES="yes"

Gemfile

@@ -9,6 +9,19 @@ group :test do
   gem 'puppetlabs_spec_helper'
   gem 'metadata-json-lint'
   gem 'puppet-strings', git: 'git://github.com/puppetlabs/puppetlabs-strings.git'
+  gem 'puppet-lint-absolute_classname-check'
+  gem 'puppet-lint-alias-check'
+  gem 'puppet-lint-empty_string-check'
+  gem 'puppet-lint-file_ensure-check'
+  gem 'puppet-lint-file_source_rights-check'
+  gem 'puppet-lint-fileserver-check'
+  gem 'puppet-lint-leading_zero-check'
+  gem 'puppet-lint-spaceship_operator_without_tag-check'
+  gem 'puppet-lint-trailing_comma-check'
+  gem 'puppet-lint-undef_in_function-check'
+  gem 'puppet-lint-unquoted_string-check'
+  gem 'puppet-lint-variable_contains_upcase'
+  gem 'rubocop'
 end
 
 group :development do