Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add optional parameter plugindir (Directory containing kibana plugins) #71

Merged
merged 1 commit into from
Feb 8, 2023
Merged

Add optional parameter plugindir (Directory containing kibana plugins) #71

merged 1 commit into from
Feb 8, 2023

Conversation

phaedriel
Copy link

Pull Request (PR) description

  • Add parameter plugindir to manage owner/group/mode

This Pull Request (PR) fixes the following issues

@phaedriel phaedriel changed the title Add parameter plugindir (Directory containing kibana plugins) Add optional parameter plugindir (Directory containing kibana plugins) Jan 7, 2023
smortex
smortex reviewed Feb 7, 2023
View reviewed changes
Copy link
Member

@smortex smortex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just a few little improvements I added as in-line comments.

manifests/init.pp Outdated Show resolved Hide resolved
data/common.yaml Outdated Show resolved Hide resolved
manifests/config.pp Outdated Show resolved Hide resolved
@phaedriel
Copy link
Author

phaedriel commented Feb 7, 2023 •
edited
Loading

made, sync and rebase.
but i had a trouble (pipeline "static validation" was in error) with Guardfile (it was in .gitignore).
I did this before new rebase
git rm -r --cached . && git add . && git commit -am "Remove ignored files"

smortex
smortex approved these changes Feb 7, 2023
View reviewed changes
Copy link
Member

@smortex smortex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@smortex smortex added the enhancement New feature or request label Feb 7, 2023
@smortex
Copy link
Member

smortex commented Feb 7, 2023

@phaedriel I just merged #72 which touched some area common with this PR and is now causing conflict. Can you please rebase your changes on top of master and fix the conflicts before force-pushing to update the PR?

Thanks!

@smortex smortex merged commit 34bf695 into voxpupuli:master Feb 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@smortex smortex smortex approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

kibana plugin installation and directory permissions issue
3 participants
@phaedriel @smortex @stjmt