Changed Integer parameters into Icinga2::Interval #654
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Where applicable I changed to parameter types to Icinga2::Interval. This makes the module more uniform and predictable. Signed-off-by: Henry Pauli <[email protected]>
|
I don't understand, what's the point? And what do I do with values like 1m, 4h, etc. |
|
That's the whole point, currently values like 1m are not allowed in checkcommand, eventcommand or notificationcommand. This change changes this to for example: https://github.com/Icinga/puppet-icinga2/blob/b6f9edeca38471786d2bb6f3caaa8b9d02a7eecf/manifests/object/service.pp#L159 |
|
Good point but I think we will change to Interval in checkcommand, eventcommand and so on... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Where applicable I changed to parameter types to Icinga2::Interval.
This makes the module more uniform and predictable.
Signed-off-by: Henry Pauli [email protected]