Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RHEL 8 support #600

Merged
merged 3 commits into from
Jan 10, 2020
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .bundle/config
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
---
BUNDLE_JOBS: "4"
BUNDLE_PATH: "vendor/bundle"
BUNDLE_PATH: ".vendor/bundle"
BUNDLE_DISABLE_SHARED_GEMS: "true"
BUNDLE_WITHOUT: "system_tests"
BUNDLE_BUILD: "--no-ri --no-rdoc"
BUNDLE_WITHOUT: "system_tests"
4 changes: 2 additions & 2 deletions Gemfile
Original file line number Diff line number Diff line change
Expand Up @@ -77,7 +77,7 @@ end
gem 'puppetlabs_spec_helper', '>= 2.0'
gem 'puppet-lint', '>= 2.0.0'
gem 'facter', '>= 2.4.0'
gem 'facterdb', '>= 0.5'
gem 'facterdb', '>= 1.0.0'
gem 'rspec-puppet-facts', '>= 1.6.0'
gem 'serverspec'
gem 'r10k'
Expand All @@ -87,4 +87,4 @@ gem 'beaker-rspec'
gem 'beaker-vagrant'
gem 'beaker-puppet_install_helper'

# vim: syntax=ruby
# vim: syntax=ruby
6 changes: 0 additions & 6 deletions examples/init_repo.pp
Original file line number Diff line number Diff line change
Expand Up @@ -4,12 +4,6 @@
} # RedHat
}

case $::osfamily {
'redhat': {
package { 'epel-release': }
} # RedHat
}

lbetz marked this conversation as resolved.
Show resolved Hide resolved
class { 'icinga2':
manage_repo => true,
}
9 changes: 6 additions & 3 deletions metadata.json
Original file line number Diff line number Diff line change
Expand Up @@ -30,21 +30,24 @@
"operatingsystem": "CentOS",
"operatingsystemrelease": [
"6",
"7"
"7",
"8"
]
},
{
"operatingsystem": "RedHat",
"operatingsystemrelease": [
"6",
"7"
"7",
"8"
]
},
{
"operatingsystem": "OracleLinux",
"operatingsystemrelease": [
"6",
"7"
"7",
"8"
]
},
{
Expand Down
11 changes: 6 additions & 5 deletions spec/acceptance/class_spec.rb
Original file line number Diff line number Diff line change
Expand Up @@ -5,10 +5,8 @@
describe 'with API, IDO mysql and pgsql' do
let(:pp) do
<<-MANIFEST
case $::osfamily {
'redhat': {
if $facts['os']['name'] == 'centos' and Integer($facts['os']['release']['major']) < 8 {
package { 'epel-release': }
} # RedHat
}
class { 'icinga2':
manage_repo => true,
Expand Down Expand Up @@ -63,8 +61,11 @@ class { 'icinga2::feature::api':
end

describe service('icinga2') do
it { should be_enabled }
it { should be_running }
it { is_expected.to be_running }
end

describe port(5665) do
it { is_expected.to be_listening }
end

describe command("mysql icinga2 -Ns -e 'select version from icinga_dbversion;'") do
Expand Down
12 changes: 12 additions & 0 deletions spec/acceptance/nodesets/centos-8-x64.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,12 @@
---
HOSTS:
i2centos8:
roles:
- agent
- default
platform: el-8-x86_64
hypervisor: vagrant
box: bento/centos-8
vagrant_memsize: 1024
CONFIG:
type: aio