Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove soft depedencies from metadata.json #385

Merged
merged 2 commits into from
Oct 5, 2017
Merged

Remove soft depedencies from metadata.json #385

merged 2 commits into from
Oct 5, 2017

Conversation

noqqe
Copy link
Contributor

@noqqe noqqe commented Oct 5, 2017

Hi,

the puppet styleguide recommends moving soft dependencies out of the metadata.json file. See https://docs.puppet.com/puppet/4.9/style_guide.html#dependencies

This way I don't get zypprepo and chocolatey installed in a debian-only environment.

Other projects also apply this

voxpupuli/puppet-puppetboard#185
theforeman/puppet-puppet#234

Copy link

@walterheck walterheck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agree with bringing back the dependencies to the required ones

metadata.json Outdated
@@ -14,9 +14,6 @@
"dependencies": [
{ "name": "puppetlabs/stdlib", "version_requirement": ">= 4.16.0 < 5.0.0" },
{ "name": "puppetlabs/concat", "version_requirement": ">= 2.0.1 < 5.0.0" },

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The comma at the end of this line is breaking the build..

@noqqe
Copy link
Contributor Author

noqqe commented Oct 5, 2017

Fixed the syntax error. Thanks to @walterheck

@bobapple bobapple merged commit c69685e into voxpupuli:master Oct 5, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants