Replace validate_* with data types #350
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
baurmatt
force-pushed
the
fix/performance-issues
branch
from
92e046c to
5b5a5df
Compare
baurmatt
force-pushed
the
fix/performance-issues
branch
2 times, most recently
from
a4effe1 to
fb2c28c
Compare
|
I'm friendly on removing Puppet 3 support for puppet-icinga2. @lbetz @bobapple Can I get your opinion on that. Strategy:
|
|
Let's discuss this in #362 - I would like to merge this PR here afterwards |
baurmatt
force-pushed
the
fix/performance-issues
branch
6 times, most recently
from
27e320f to
398fc2e
Compare
Added cloudlinux to supported operating systems. Is nearly identical …
Version 1.3.5
Bug/do not quote null 433
XenServer is an Citrix appliance based on CentOS 7. Tested to work.
Support manage_repo on XenServer
…gger-a-refresh-on-puppet3-434'
Due to killed tests in Travis a lot of builds fail. This commit lower the parallel tests to 4 PARALLEL_TEST_PROCESSORS
baurmatt
force-pushed
the
fix/performance-issues
branch
from
398fc2e to
e7542ca
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To drastically improve the performance of this module, all validate_* functions get replaced in this PR with data types. Therefor this PR also drops support for Puppet 3!
Fixes #345