Allow alternate restart command #249
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
A restart isn't necessary for Icinga 2. So we can replace the default restart with a generally reload. |
|
Related to #250 |
|
Closed in favour of 671f407 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is inspired by the puppetlabs-apache module. It allows for an alternate restart command to be used to restart the service, rather than completely stopping and starting it.
I'm using this to call reload on the service instead of restart. If the configuration is broken this fails the Puppet run (because reload checks the config before proceeding) rather than stopping and then failing to start Icinga, which is not desirable. This might not suit everyone thus making it optional.
If no additional parameter is given when calling the icinga2 class this change is a noop, so it won't affect any existing installations.