enable setting of bind_host and bind_port for feature::api #243
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Documentation is missing. |
aschaber1
force-pushed
the
feature/api_bind_settings
branch
from
2c3fc96 to
1369a22
Compare
aschaber1
force-pushed
the
feature/api_bind_settings
branch
from
1369a22 to
e09ec2e
Compare
|
added documentation and parameter validation |
|
LGTM, added spec Travis failing is not related to that change. |
|
Offtopic: |
|
@Reamer as a project contributor you see: I can actually directly push to his repository on that branch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
usecase: I need to set bind_host to '::' for ipv6 listening.