Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change all TLS certificates and keys to datatype Stdlib::Base64 #623

Closed
lbetz opened this issue Jul 17, 2020 · 2 comments
Closed

Change all TLS certificates and keys to datatype Stdlib::Base64 #623

lbetz opened this issue Jul 17, 2020 · 2 comments
Milestone
v3.0.0

Comments

@lbetz
Copy link
Contributor

lbetz commented Jul 17, 2020

No description provided.

@lbetz lbetz added this to the v3.0.0 milestone Jul 17, 2020
@lbetz lbetz removed the enhancement label Oct 6, 2020
@lbetz lbetz mentioned this issue Oct 6, 2020
Merged
@lbetz lbetz closed this as completed in 7d4a0d7 Oct 6, 2020
lbetz added a commit that referenced this issue Oct 6, 2020
@lbetz
Merge pull request #640 from Icinga/enhancement/change-data-types-of-…
579c138 
…all-certs-and-keys-623

fix #623 change data types of all certificates and keys
@DeadHunter
Copy link

Has this ever been tested? Stdlib::Base64 does not include all chars for a cert file.

https://github.com/puppetlabs/puppetlabs-stdlib/blob/v7.1.0/types/base64.pp

parameter 'ssl_key' expects a match for Stdlib::Base64 = Pattern[/\A[a-zA-Z0-9\/\+]+={,2}\z/], got '-----BEGIN RSA PRIVATE KEY----- ....

@lbetz
Copy link
Contributor Author

lbetz commented Dec 14, 2022 •
edited
Loading

Your right. Icinga isn't really interested in puppet, so it has probably not been tested and obviously no one has used TLS this way since for almost 2 years. I will open an issue and fix it.

@lbetz lbetz mentioned this issue Dec 14, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v3.0.0
Development

No branches or pull requests
2 participants
@lbetz @DeadHunter