ido schema import dependency

[snahelou]

Hello guys,

I tested your module in my dev env and I think you have some bugs with your icinga2::feature::idopgsql

First is a missing dependent when import schema is false.

  if $ido_pgsql_package {
    package { $ido_pgsql_package:
      ensure => installed,
      before => [
        Exec['idopgsql-import-schema'],
        Icinga2::Feature['ido-pgsql'],
      ]
    }
  }

  if $import_schema {
    exec { 'idopgsql-import-schema':
      user        => 'root',
      path        => $::path,
      environment => ["PGPASSWORD=${password}"],
      command     => "psql -h '${host}' -U '${user}' -d '${database}' -w -f /usr/share/icinga2-ido-pgsql/schema/pgsql.sql",
      unless      => "psql -h '${host}' -U '${user}' -d '${database}' -w -c 'select version from icinga_dbversion'",
    }
  }

You will have

Error: Failed to apply catalog: Could not find dependent Exec[idopgsql-import-schema] for Package[icinga2-ido-pgsql] at /etc/puppet/environments/production/modules/icinga2/manifests/feature/idopgsql.pp:113

Second is with your import schema exec command which not support a custom port

  if $import_schema {
    exec { 'idopgsql-import-schema':
      user        => 'root',
      path        => $::path,
      environment => ["PGPASSWORD=${password}"],
      command     => "psql -h '${host}' -U '${user}' -d '${database}' -w -f /usr/share/icinga2-ido-pgsql/schema/pgsql.sql",
      unless      => "psql -h '${host}' -U '${user}' -d '${database}' -w -c 'select version from icinga_dbversion'",
    }
  }

Notice: /Stage[main]/Icinga2::Feature::Idopgsql/Exec[idopgsql-import-schema]/returns: psql: could not connect to server: Connection refused
Notice: /Stage[main]/Icinga2::Feature::Idopgsql/Exec[idopgsql-import-schema]/returns: 	Is the server running on host "127.0.0.1" and accepting
Notice: /Stage[main]/Icinga2::Feature::Idopgsql/Exec[idopgsql-import-schema]/returns: 	TCP/IP connections on port 5432?
Error: psql -h '127.0.0.1' -U 'icinga2' -d 'icinga2' -w -f /usr/share/icinga2-ido-pgsql/schema/pgsql.sql returned 2 instead of one of [0]
Error: /Stage[main]/Icinga2::Feature::Idopgsql/Exec[idopgsql-import-schema]/returns: change from notrun to 0 failed: psql -h '127.0.0.1' -U 'icinga2' -d 'icinga2' -w -f /usr/share/icinga2-ido-pgsql/schema/pgsql.sql returned 2 instead of one of [0]

Hope it can help you

Regards

[lbetz]

Yes, you're right. The dependency points to /dev/null if the schema is'nt manmaged. The same problem for mysql.