Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update docs of example4 with hint for Puppet 4 #234

Closed
bobapple opened this issue Feb 20, 2017 · 2 comments
Closed

Update docs of example4 with hint for Puppet 4 #234

bobapple opened this issue Feb 20, 2017 · 2 comments
Assignees
Milestone

Comments

@bobapple
Copy link
Contributor

Looks like Puppet Forge is testing the examples for validation. In our rake task we disable examples explicitly from testing.

With Puppet 3.x validation fails for example4:

root@icinga2-puppet3:~/modules/icinga2# for file in `find . -name "*.pp" -type f`; do puppet parser validate $file; done
Error: Could not parse for environment production: Syntax error at '*'; expected '}' at /root/modules/icinga2/examples/example4/profile/manifests/agent.pp:51
Error: Could not parse for environment production: Syntax error at '*'; expected '}' at /root/modules/icinga2/examples/example4/profile/manifests/slave.pp:67
@bobapple bobapple added the bug label Feb 20, 2017
@lbetz lbetz self-assigned this Feb 27, 2017
@bobapple bobapple added this to the v1.1.1 milestone Feb 28, 2017
@bobapple
Copy link
Contributor Author

bobapple commented Mar 8, 2017

Looks like puppet forge is ignoring examples now, quality score is up to 4.7 again.
I think it's sufficient to add a note somewhere that this example is only for Puppet 4, if not already included.

@lbetz lbetz added enhancement and removed bug labels Mar 12, 2017
@lbetz
Copy link
Contributor

lbetz commented Mar 12, 2017

add a comment that the example is for puppet 4 only

@lbetz lbetz closed this as completed in 1124f38 Mar 12, 2017
@bobapple bobapple changed the title Fix example4 for Puppet 3.x Update docs of example4 with hint for Puppet 4 Mar 13, 2017
n00by pushed a commit to n00by/puppet-icinga2 that referenced this issue Apr 26, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants