fixes issue with new backend merge logic #156
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* the eyaml_gpg_keygen variable is not used and causes
testing to fail during gpg testing
logicminds
force-pushed
the
backends
branch
2 times, most recently
from
70be1c1 to
3472d8c
Compare
* previously before using deep_merge the data from hiera
was not being merged correctly causing the user to have to
define all the eyaml data upfront instead of taking defaults
* also fixes a problem where eyaml-gpg data was being declared
in the hiera.yaml file when it should not have been
logicminds
force-pushed
the
backends
branch
2 times, most recently
from
afebe60 to
923c610
Compare
|
I assumed hiera was able to read yaml files with or without the usage of symbols and covert them to the correct type. However it turns out that many of the backends require the usage of symbols for their options if not all. I assume this will be backend specific but there is just now way to tell unless you look at the backend code. More importantly this would probably cover 95% of the cases. The template will actually convert to symbols which is probably safer given that most folks don't know what ruby symbols are and have no idea how to use them with yaml. Without this fix the previously submitted code is not fully functional. |
logicminds
force-pushed
the
backends
branch
3 times, most recently
from
d03fa27 to
1f3abb6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.