Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added external_port parameter #93

Merged
merged 1 commit into from
Sep 16, 2016

Conversation

blakejakopovic
Copy link
Contributor

I'm using Gitlab that sit's behind an Nginx reverse proxy, and needed to change the external port. So I've added the external_port parameter. Note that to successfully use a different port, you need to add the port to the external_url as well. I'm currently using this fork, and it works as expected. I've also added a basic test. Please let me know if you have any concerns.

class { 'gitlab':
  external_url  => 'http://domain.name:5555',
  external_port => 5555,
}

@tobru tobru merged commit 8c60208 into voxpupuli:master Sep 16, 2016
@tobru
Copy link
Contributor

tobru commented Sep 16, 2016

Great! Thanks a lot for your contribution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants