Feature/master/systemd compatibility

[bjeske]

Ensure => 'absent' for initd softlink on systems with systemd like ubuntu 16.04 etc.

[petems]

It might be better to simplify this to use the systemd fact:

https://github.com/camptocamp/puppet-systemd/blob/master/lib/facter/systemd.rb

This would mean this patch would also work on RHEL flavoured systems with systemd (Centos 7, Oracle Linux 7, Fedora 14+ etc)

[bjeske]

This is not a core fact, right? So we would need a dependency for puppet-systemd... I'm not so sure if this is a good decision? As of Ubuntu 16.04 with facter 1.7.5 this fact is not present.

[petems]

It's not a core fact unfortunately no. Adding a dependency is one option, but seems a bit heavy handed for just one fact.

However, it could be added as a fact to this module with it's own namespace (eg. gitlab_systemd_check or something), using only the code for the systemd check from the linked fact:

Facter.add(:gilab_systemd_check) do
  confine :kernel => :linux
  setcode do
    Facter::Core::Execution.exec('ps -p 1 -o comm=') == 'systemd'
  end
end

The benefit of adding the fact would be that the code becomes a lot more manageable:

if ($::gilab_systemd_check) {

[bjeske]

It seems "Facter::Core::Execution" is not present in facter 1.7.5, which comes with Ubuntu 16.04.
I had to use the "old %x" Sysntax to make this work:

Facter.add(:gitlab_systemd) do
  confine :kernel => :linux
  setcode do
    %x{ps -p 1 -o comm=}.gsub("\n",'') == 'systemd'
  end
end

Or did i miss something here?

[petems]

Using backticks/%x or Kernel.exec will ignore the confine, so it will run on any system rather than be restricted to Linux (eg. Windows, OSX, BSD).

Good spot, It should be Facter::Util::Resolution.exec which is backwards compatible:
http://www.rubydoc.info/gems/facter/1.7.5/Facter/Util/Resolution.exec
http://www.rubydoc.info/gems/facter/2.4.6/Facter/Util/Resolution.exec

Facter.add(:gitlab_systemd) do
  confine :kernel => :linux
  setcode do
     Facter::Util::Resolution.exec('ps -p 1 -o comm=') == 'systemd'
  end

end

I'll open a PR against the systemd repo for that to fix that! 👍

[bjeske]

Seems like i was a bit fast claiming 16.04 comes with 1.7.5... Not so sure if we enforce this facter version for one reason or another somewhere... 2.4.6 seems to be in 16.04.

[petems]

Heh, I think it depends if you're using Ubuntu upstreams or Puppet's ones 😄

Either way, Util resolution is the right way 👍

[petems]

This probably needs changing to "default for systemd systems, as determined by the $:: gitlab_systemd fact

[tobru]

@bjeske Thanks a lot for your contribution. Before I can merge it could you please make sure that all tests passes? And if you could do a rebase so we only have one commit to merge would also be great.

[petems]

@tobru I've rebased, squashed and added tests for this PR in #94, as I'm looking to move to the upstream for a customer rather than a fork.

@bjeske The commit is still under your name in the new PR, but squashed and tests fixed

[tobru]

Merged in #94