Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Redirect stderr for backup cron to stdout #351

Merged
merged 1 commit into from
Aug 12, 2020
Merged

Redirect stderr for backup cron to stdout #351

merged 1 commit into from
Aug 12, 2020

Conversation

baurmatt
Copy link
Contributor

Pull Request (PR) description

This ensures that all errors get properly send by mail in events of
failure.

This Pull Request (PR) fixes the following issues

igalic
igalic approved these changes Aug 11, 2020
View reviewed changes
Copy link

@igalic igalic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you'd think setting an environment variable named CRON would instruct gitlab to behave correctly…

@vox-pupuli-tasks
Copy link

Dear @baurmatt, thanks for the PR!

This is Vox Pupuli Tasks, your friendly Vox Pupuli Github Bot. I noticed that your pull request has CI failures. Can you please have a look at the failing CI jobs?
If you need any help, you can reach out to us on our IRC channel voxpupuli on Freenode or our Slack channel voxpupuli at slack.puppet.com.
You can find my sourcecode at voxpupuli/vox-pupuli-tasks

@vox-pupuli-tasks
Copy link

Dear @baurmatt, thanks for the PR!

This is Vox Pupuli Tasks, your friendly Vox Pupuli GitHub Bot. I noticed that your pull request contains merge conflict. Can you please rebase?

You can find my sourcecode at voxpupuli/vox-pupuli-tasks

1 similar comment
@vox-pupuli-tasks
Copy link

Dear @baurmatt, thanks for the PR!

This is Vox Pupuli Tasks, your friendly Vox Pupuli GitHub Bot. I noticed that your pull request contains merge conflict. Can you please rebase?

You can find my sourcecode at voxpupuli/vox-pupuli-tasks

@baurmatt
Redirect stderr for backup cron to stdout
98b6c6b 
This ensures that all errors get properly send by mail in events of
failure.
@baurmatt
Copy link
Contributor Author

Tests have been failing because of unrelated puppet-lint errors. This has been fixed in #352 and this branch was rebased.

@baurmatt baurmatt merged commit 4d5aad8 into voxpupuli:master Aug 12, 2020
@baurmatt baurmatt deleted the backup-stderr branch August 12, 2020 14:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@igalic igalic igalic approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@baurmatt @igalic