Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove service dependency cycle by dropping management of the gitlab-runsvdir service #293

Merged
merged 6 commits into from
Dec 25, 2018
Merged

Remove service dependency cycle by dropping management of the gitlab-runsvdir service #293

merged 6 commits into from
Dec 25, 2018

Conversation

LongLiveCHIEF
Copy link
Contributor

fixes #284

@bastelfreak bastelfreak added the needs-feedback Further information is requested label Dec 15, 2018
@LongLiveCHIEF LongLiveCHIEF removed the needs-feedback Further information is requested label Dec 15, 2018
@LongLiveCHIEF
Copy link
Contributor Author

@bastelfreak let me know if my response makes sense. Coincidentally, this is also why no new tests were needed.

@LongLiveCHIEF LongLiveCHIEF added the needs-work not ready to merge just yet label Dec 15, 2018
@LongLiveCHIEF
Copy link
Contributor Author

actually, i do need to make some unit test changes. (service expectations). Still on the fence about the major version change, and would like input from contributors on that bit.

@LongLiveCHIEF LongLiveCHIEF removed the needs-work not ready to merge just yet label Dec 20, 2018
@bastelfreak bastelfreak added the bug Something isn't working label Dec 25, 2018
@bastelfreak
Copy link
Member

Thanks @LongLiveCHIEF !

@bastelfreak bastelfreak merged commit ad2ebae into voxpupuli:master Dec 25, 2018
@alexjfisher alexjfisher mentioned this pull request Apr 29, 2019
Closed
@baurmatt baurmatt changed the title remove service dependency cycle Remove service dependency cycle by dropping management of the gitlab-runsvdir service Apr 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bastelfreak bastelfreak bastelfreak left review comments

Assignees
No one assigned
Labels
backwards-incompatible bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Dependency error when gitlab::service::service_manage is set to false
3 participants
@LongLiveCHIEF @bastelfreak @alexjfisher