Add gitlab-consul auth for pgbouncer database #255
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bastelfreak
reviewed
Jul 11, 2018
templates/.pgpass.erb
Outdated
| @@ -0,0 +1 @@ | |||
| 127.0.0.1:*:pgbouncer:pgbouncer:<%= @pgbouncer_password -%> | |||
There was a problem hiding this comment.
Can you please provide this an an epp template?
From our guidelines;
Is a new template added? The preferred language is epp, not erb
Please provide the needed variable as parameter.
There was a problem hiding this comment.
sure, will do.
|
Thanks for the enhancement @LongLiveCHIEF, can you please take a look at the inline comments I made? |
|
@bastelfreak changed to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This enhancement allows for the configuration of the authentication required for enabling built in database failover/service discovery. This PR adds configuration for the file the gitlab-omnibus package uses to authenticate the service discovery agent (consul) against the pgbouncer database.
closes #229