Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove auto-execution of gitlab:setup #210

Merged
merged 1 commit into from
Mar 31, 2018

Conversation

LongLiveCHIEF
Copy link
Contributor

This code block was valid in older versions of gitlab, but in 10.x versions, there are several situations where you would be managing the gitlab service and had configurations in the postgresql hash, and have postgresql disabled, or merely not indicate and let the default psql config for the enable setting be utilized by omnibus chef. (for example, gitlab HA configurations for database roles/nodes, or when providing your own psql database)

Additionally, the git_data_dir is no longer a valid param, and the postgres configuration doesn't use teh setup.complete file at this path any more. This causes gitlab to re-perform setup on each puppet run if you have postgres configurations but don't explictly indicate enable => true

Fixes #35
Fixes #195

@LongLiveCHIEF LongLiveCHIEF added this to the Gitlab HA Support milestone Mar 31, 2018
@bastelfreak bastelfreak added backwards-incompatible docs Improvements or additions to documentation labels Mar 31, 2018
@bastelfreak
Copy link
Member

Thanks @LongLiveCHIEF ! Can you please create feature branches in a fork, and not in the org repo?

@bastelfreak bastelfreak merged commit b5f4da8 into master Mar 31, 2018
@bastelfreak bastelfreak added bug Something isn't working and removed docs Improvements or additions to documentation labels Mar 31, 2018
@LongLiveCHIEF LongLiveCHIEF deleted the 35-remove-auto-execution-of-gitlab-setup branch June 8, 2018 22:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backwards-incompatible bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants