remove auto-execution of gitlab:setup #210
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This code block was valid in older versions of gitlab, but in 10.x versions, there are several situations where you would be managing the gitlab service and had configurations in the
postgresql
hash, and have postgresql disabled, or merely not indicate and let the default psql config for theenable
setting be utilized by omnibus chef. (for example, gitlab HA configurations for database roles/nodes, or when providing your own psql database)Additionally, the
git_data_dir
is no longer a valid param, and the postgres configuration doesn't use tehsetup.complete
file at this path any more. This causes gitlab to re-perform setup on each puppet run if you have postgres configurations but don't explictly indicateenable => true
Fixes #35
Fixes #195