Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RHEL 7 support #2

Merged
merged 2 commits into from
Jun 17, 2015
Merged

RHEL 7 support #2

merged 2 commits into from
Jun 17, 2015

Conversation

danfoster
Copy link
Contributor

This PR addresses some problems to fix some issues RHEL 7 support.

  1. Use $releasever instead of the hardcoded 5 in the baseurl for the yumrepo.
  2. Don't force the upstart service type if it's a redhat family machine. Let puppet infer that it's systemd.
  3. Because the chef installer symlinks the systemd service to /etc/systemd/system/default.target.wants/gitlab-runsvdir.service, it is not enableable. But it gets started on boot due to it being under default.target.wants. The work-around is just to tell puppet not to try and enable the service.

For info, you get the following error in you try to enable the service.

# systemctl enable gitlab-runsvdir
Failed to issue method call: No such file or directory

tobru added a commit that referenced this pull request Jun 17, 2015
@tobru tobru merged commit 2c0a516 into voxpupuli:master Jun 17, 2015
@tobru
Copy link
Contributor

tobru commented Jun 17, 2015

Thanks a lot for this PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants