Remove deprecated hiera and validation functions #119
Conversation
|
Need help here, I don't know why the yaml is generated wrong. |
manifests/config.pp
Outdated
| @@ -83,15 +83,15 @@ | |||
| if $config_manage { | |||
| if $source_config_file { | |||
| file { $config_file: | |||
| ensure => file, | |||
There was a problem hiding this comment.
why change this to present, file is much more descriptive and does the same thing (i thought puppet-lint flagged this but dont see it on their we site)
There was a problem hiding this comment.
I don't know why I'm doing this the last six month. I will change it back.
|
can you give more info on the issue, happy to help with this |
|
I'll take a rebase and rollback the changes on the ensure attributes. |
jkroepke
force-pushed
the
puppet4
branch
8 times, most recently
from
7c2af9a to
8e7320b
Compare
jkroepke
force-pushed
the
puppet4
branch
6 times, most recently
from
8d2857d to
45852ba
Compare
jkroepke
changed the title
jkroepke
force-pushed
the
puppet4
branch
6 times, most recently
from
43e9a43 to
81d7cc2
Compare
jkroepke
force-pushed
the
puppet4
branch
2 times, most recently
from
a531740 to
2be5d16
Compare
|
Sorry for some possible notification spam. Any chances to get merged this PR? Rebasing this PR everytime is a hard doing. |
| comment => 'GitlabCI Runner Repo', | ||
| location => "${repo_base_url}/runner/${package_name}/${distid}/", | ||
| release => $::lsbdistcodename, | ||
| location => "${repo_base_url}/runner/${package_name}/${::lsbdistid.downcase}/", |
There was a problem hiding this comment.
This is a legacy fact. Can you switch it to a modern fact please?
There was a problem hiding this comment.
If you want to fix the sped tests, sure. I tried to used the modern facts, but the lib rspec-puppet-facts doesn‘t provide modern facts and I get tons of error in travis.
There was a problem hiding this comment.
nah, sounds like out of scope for this PR in that case. We'll fix it in another issue/PR.
|
|
||
| if ! ($content) and ! ($source) { | ||
| fail('gitlab::custom_hook resource must specify either content or source') | ||
| fail("gitlab::custom_hook[${name}]: Must specify either content or source") |
metadata.json
Outdated
| @@ -68,7 +68,7 @@ | |||
| "requirements": [ | |||
| { | |||
| "name": "puppet", | |||
| "version_requirement": ">=3.7.0 <5.0.0" | |||
| "version_requirement": ">=4.6.1 <5.0.0" | |||
There was a problem hiding this comment.
shouldn't the version_requirement here now be ">=4.6.1 <6.0.0 instead of 5.0.0?
There was a problem hiding this comment.
Yeah, I created this PR so long ago.
There was a problem hiding this comment.
I feel you. I've got a few of my own that have had to be rebased a handful of times.
…ns with puppet data types
|
So I fixed the lint issues from master, too. |
Related #118
gitlab_systemdDockerfileto run rspec tests locally without setup a dev environment.