drop legacy is_hash method, replace topscope fact with facts hash #107
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your PR. We're not yet ready to deprecate Puppet 3 support, this will happen over the next weeks. |
bastelfreak
reviewed
Mar 30, 2018
manifests/install.pp
Outdated
| } else { | ||
| $releasever = $::operatingsystemmajrelease | ||
| } | ||
| $releasever = $::os[release][major] |
There was a problem hiding this comment.
this should be $facts['os']['release']['major']
|
@james-powis thanks for the PR, can you please rebase? |
bastelfreak
added
needs-docs
needs-rebase
needs-work
james-powis
force-pushed
the
remove_hash_check
branch
5 times, most recently
from
c5aa197 to
2504c90
Compare
remove support for < 4.0.0
james-powis
force-pushed
the
remove_hash_check
branch
from
2504c90 to
2a570fd
Compare
|
@bastelfreak Done and done, we should be good to go... as $::operatingsystemmajrelease is legacy status, I reverted the changes which were introduced in 3fa7b17 which 80% covered this PR. |
|
Thanks! |
bastelfreak
changed the title
bastelfreak
added
enhancement
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the $::os fact hash has been around since 3.5 (and puppet 3 is EOL) this change removes the is_hash dependency provided by stdlib (which is deprecated).
Supporting references:
https://github.com/puppetlabs/puppetlabs-stdlib#is_hash
Replacements for the is_ functions:
In param block: https://github.com/puppetlabs/puppetlabs-ntp/blob/master/manifests/init.pp#L17-L28
In code block: https://docs.puppet.com/puppet/4.8/lang_expressions.html#regex-or-data-type-match
Note: both of the replacements for is_* are only compatible with puppet 4.0.0 and later, I have updated the metadata.json to reflect this, and I would recommend releasing a new major release version to the forge.