Merge pull request #68 from gerhardsam/cirunner/fix_supported_os

Fix cirunner failure-message for unsupported OS families
voxpupuli · Mar 23, 2016 · f15d398 · f15d398
2 parents 9850c49 + cd03a4d
commit f15d398
Show file tree

Hide file tree

Showing 2 changed files with 14 additions and 1 deletion.
diff --git a/manifests/cirunner.pp b/manifests/cirunner.pp
@@ -36,7 +36,7 @@
   validate_bool($manage_repo)
 
   unless ($::osfamily == 'Debian' or $::osfamily == 'RedHat')  {
-    fail ("OS family ${::osfamily} is not supported. Only Debian is suppported.")
+    fail ("OS family ${::osfamily} is not supported. Only Debian and Redhat is suppported.")
   }
 
   if $manage_docker {

diff --git a/spec/classes/cirunner_spec.rb b/spec/classes/cirunner_spec.rb
@@ -58,5 +58,18 @@
 
     end
   end
+  context 'unsupported operating systems' do
+    describe "gitlab::cirunner class without any parameters on unsupported OS" do
+      let(:params) {{ }}
+      let(:facts) {{
+         :osfamily => 'unsupported_os_family',
+      }}
+      it "should fail" do
+        expect do
+          catalogue
+        end.to raise_error(Puppet::Error, /OS family unsupported_os_family is not supported. Only Debian and Redhat is suppported./)
+      end
+    end
+  end
 
 end