Use 'lookup' function instead of 'hiera' #45
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
'hiera' function is deprecated in puppet5 https://puppet.com/docs/puppet/5.0/hiera_migrate_functions.html 'lookup' function is supported for all puppet version from requirements.version_requirement
alexjfisher
requested changes
Nov 27, 2018
|
The explicit hiera calls should go for sure. |
|
@alexjfisher, @traylenator, what is final decision? Should I change something or not in PR (@alexjfisher comment still require changes)? |
|
Yes I think just delete the hiera calls and set values to their default values. |
|
I'm going to update the module to puppet 4 and in the process these hiera calls will go. |
OK, then I just close this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request (PR) description
'hiera' function is deprecated in puppet.
https://puppet.com/docs/puppet/5.0/hiera_migrate_functions.html
'lookup' function is supported by all puppet versions from
requirements.version_requirement
This Pull Request (PR) fixes the following issues
Warning: The function 'hiera' is deprecated in favor of using 'lookup'. See https://puppet.com/docs/puppet/<VERSION>/deprecated_language.html\n (file & line not available)