Other attempt to call Facter to find osfamily #590
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
buzzdeee
referenced
this pull request
Feb 27, 2016
class down to the native plugins type. That's necessary for installations in non-default locations. Retrieve plugindir value from parameter given to init.pp in the plugin.pp provider for elasticsearch_plugin type, special case OpenBSD a bit, export variable ES_INCLUDE as well as the JAVA_HOME variable. For ES_INCLUDE, use the same path that is also specified in the rc script. For JAVA_HOME, use the javaPathHelper, to retrieve the correct path for elasticsearch. Also very similar to what the rc script does.
|
Jenkins standing by to test this. If you aren't a maintainer, you can ignore this comment. Someone with commit access, please review this and clear it for Jenkins to run; then say 'jenkins, test it'. |
|
Thanks @buzzdeee |
|
Thanks @buzzdeee, this looks totally safe and technically correct. Did a close/re-open dance to get it into a Travis PR build test, hope it's cool I'm using this as a guinea pig for some CI refactors. 🐧 |
|
Hey @buzzdeee, I think I've worked out the kinks in CI and am ready for this. Can you update this branch onto the latest master and when it passes, we'll be good to go 👍 |
…n.rb to find out 'osfamily'
|
long easter weekend (: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
in provider/elasticsearch_plugin/plugin.rb
this is to fix the issue @benlangfeld reported here:
cc1e6b9#commitcomment-16365111
using his suggested fix, and at least does also work for me on OpenBSD.