Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Elasticsearch 7 to test matrix #1088

Merged
merged 9 commits into from
Jul 9, 2020
Merged

Add Elasticsearch 7 to test matrix #1088

merged 9 commits into from
Jul 9, 2020

Conversation

fatmcgav
Copy link
Contributor

@fatmcgav fatmcgav commented Jun 16, 2020 •
edited
Loading

Add Elasticsearch 7.7.1 to the test matrix, and update supporting code and tests to support.

Also added Ubuntu 20.04 to the test matrix.

@fatmcgav fatmcgav self-assigned this Jun 16, 2020
@fatmcgav fatmcgav marked this pull request as draft June 16, 2020 11:10
@fatmcgav fatmcgav changed the title <!-- The following list of checkboxes are the prerequisites for getting your contribution accepted. Please check them as they are completed. --> Add Elasticsearch 7 to test matrix Jun 16, 2020
Gavin Williams added 3 commits June 25, 2020 14:01
Fix issue with downloadin ES 7 packages that now include the
d1d95f0 
architecture in the filename.

Also remove the management of the pid_dir and defaults location, as this
is managed by the packages.
Fix lint issue on 'spec_utilities
ab6c1be
Improve handling of Index templates across ES versions.
b9eba78
@fatmcgav fatmcgav force-pushed the add_es7_test_matrix branch from dd8e94e to b9eba78 Compare June 25, 2020 13:02
@fatmcgav fatmcgav marked this pull request as ready for review June 25, 2020 13:28
@fatmcgav
Copy link
Contributor Author

This one is ready for review now.

There is still one persistent failure on CentOS/Oracle Linux 7, which appears to be due to some weird issue with installing the RPM and file permissions. Related Elasticsearch issue: elastic/elasticsearch#50631

Needs some more detailed debugging, but don't want that to hang this up too much.

@jmlrt
Copy link
Contributor

jmlrt commented Jun 25, 2020 •
edited
Loading

Add Elasticsearch 7.7.1 to the test matrix, and update supporting code and tests to support.

Can this be updated to 7.8.0?

Also added Ubuntu 20.04 to the test matrix.

Ubuntu 20.04 is not yet on the support matrix, I would prefer waiting to add it to puppet supported platforms. WDYT?

@fatmcgav
Copy link
Contributor Author

fatmcgav commented Jul 2, 2020

I've switched the default 7.x version to 7.8.0 in 86b4fb7, and also removed Ubuntu 20.04.

Thanks for the feedback @jmlrt

jmlrt
jmlrt suggested changes Jul 2, 2020
View reviewed changes
spec/acceptance/nodesets/ubuntu-server-2004-x64.yml
@@ -0,0 +1,17 @@
HOSTS:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we remove also this file?

tylerjl
tylerjl reviewed Jul 2, 2020
View reviewed changes
Copy link
Contributor

@tylerjl tylerjl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool 🍨 I'll defer to @jmlrt's feedback but the changes here make sense to me. 👍

ninaspitfire
ninaspitfire approved these changes Jul 3, 2020
View reviewed changes
Copy link
Contributor

@ninaspitfire ninaspitfire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice. 👍

@fatmcgav
Copy link
Contributor Author

fatmcgav commented Jul 3, 2020

So I pushed the branch to the elastic repo in order to trigger some of the security tests, and they all failed :(

I'm going to debug further before merging.

@fatmcgav
Copy link
Contributor Author

fatmcgav commented Jul 8, 2020

OK, I think I've found the issue with the security tests (A different Vault secret path to the one I updated with v7 license), and I'm running the job again.

@fatmcgav
Copy link
Contributor Author

fatmcgav commented Jul 9, 2020

So the tests passed with the exception of the EL7 tests which I noted above.

Merging this one in and will work on the EL7 tests in a separate PR.

@fatmcgav fatmcgav merged commit 873058e into voxpupuli:master Jul 9, 2020
@fatmcgav fatmcgav deleted the add_es7_test_matrix branch July 9, 2020 10:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tylerjl tylerjl tylerjl left review comments

@jmlrt jmlrt jmlrt requested changes

@ninaspitfire ninaspitfire ninaspitfire approved these changes

@Conky5 Conky5 Awaiting requested review from Conky5

@mgreau mgreau Awaiting requested review from mgreau

Assignees

@fatmcgav fatmcgav

Labels
es-7.x feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@fatmcgav @jmlrt @ninaspitfire @tylerjl