Add an optional key_source parameter to set up the package repository.

[gitbensons]

Our internal hosts have no access to the internet, hence no option to download GPG-KEY-elasticsearch. This tiny patch adds the option to specify the download location for the GPG file.

[cla-checker-service]

❌ Author of the following commits did not sign a Contributor Agreement:
6aa14c5

Please, read and sign the above mentioned agreement if you want to contribute to this project

[bahner]

Hepp! @gitbensons - do you have anything against signing the agreement? Otherwise I will steal your commit and repeat your work. This is important for me too.

[gitbensons]

@bahner you are free to steal the commit 🙂

[smortex]

The agreement is not required anymore: the module is now managed by voxpupuli. The transition is in progress, once #39 is merged, the CI should stop checking this 😉

[smortex]

Can you please rebase your changes on top of the main branch?

From your working directory:

git fetch origin       # Download the latest code we have here
git rebase origin/master # Move your commits on top of the main branch
git push -f            # Send the changes (-f is required because we re-wrote history)

[gitbensons]

@smortex I synced my repo with master and rebased my changes. Not sure if this actually did what you expected. Directly after pushing the changes, Github went down, so I take this as a sign :)

[smortex]

New CI proves to be useful \o/

Q: if your nodes cannot download the PGP key, how do they manage to fetch the actual packages? Are these changes really enough?

[smortex]

CI failure can be fixed by removing the Optional. While here, maybe we can use a stricter type than String, e.g. String[1] (non-empty string) or Stdlib::HTTPUrl (which would not allow puppet:///modules/profile/esGPG-KEY-elasticsearch/ so maybe not so good?). Also, missing coma at end of line 😉

Suggested change

	Optional[String] $key_source = 'https://artifacts.elastic.co/GPG-KEY-elasticsearch'
	Stdlib::HTTPUrl $key_source = 'https://artifacts.elastic.co/GPG-KEY-elasticsearch',

[bahner]

Yes. I use nexus[1], which goes out and fetches all files required. So it will just download the GPG key from you and store it in it's repo cache. It could also just use the base repo path to get this really. - bahner [1] https://www.sonatype.com/products/repository-oss søn. 28. nov. 2021 kl. 20:40 skrev Romain Tartière ***@***.***

…

: ***@***.**** commented on this pull request. New CI proves to be useful \o/ Q: if your nodes cannot download the PGP key, how do they manage to fetch the actual packages? Are these changes really enough? ------------------------------ In manifests/repo.pp <#35 (comment)> : > @@ -18,6 +18,7 @@ String $proxy = 'absent', Integer $version = 7, Optional[String] $base_repo_url = undef, + Optional[String] $key_source = 'https://artifacts.elastic.co/GPG-KEY-elasticsearch' CI failure can be fixed by removing the Optional. While here, maybe we can use a stricter type than String, e.g. String[1] (non-empty string) or Stdlib::HTTPUrl (which would not allow puppet:///modules/profile/esGPG-KEY-elasticsearch/ so maybe not so good?). Also, missing coma at end of line 😉 ⬇️ Suggested change - Optional[String] $key_source = 'https://artifacts.elastic.co/GPG-KEY-elasticsearch' + Stdlib::HTTPUrl $key_source = 'https://artifacts.elastic.co/GPG-KEY-elasticsearch', — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#35 (review)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ACNLSL2TPDWGY25QED6A2XDUOKARDANCNFSM4YCFMXSQ> . Triage notifications on the go with GitHub Mobile for iOS <https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675> or Android <https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.

-- Mvh, Lars Bahner