Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix authkey type: allow same type as file source #481

Merged
merged 1 commit into from
May 29, 2020

Conversation

Elbandi
Copy link
Contributor

@Elbandi Elbandi commented Dec 13, 2019

authkey params is used in file resource type, so set same type as source params

Fixes #480.

@vox-pupuli-tasks
Copy link

Dear @Elbandi, thanks for the PR!

This is Vox Pupuli Tasks, your friendly Vox Pupuli Github Bot. I noticed that your pull request has CI failures. Can you please have a look at the failing CI jobs?
If you need any help, you can reach out to us on our IRC channel voxpupuli on Freenode or our Slack channel voxpupuli at slack.puppet.com.
You can find my sourcecode at voxpupuli/vox-pupuli-tasks

authkey params is used in file resource type, so set same type as source params
Copy link
Member

@ekohl ekohl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Stdlib::Filesource includes Stdlib::Absolutepath so this is safe to do.

@ekohl ekohl merged commit a062493 into voxpupuli:master May 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow puppet uri for authkey
2 participants