Feat: Add pcs STONITH Resource Support #475
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In PCS environments there is a special subcommand to manage stonith primitive types: `pcs stonith` This change adds support for this special type to the pcs primitive along with associated test code to support validating these changes. Note that no testing has been done to verify whether the existing crm provider can handle stonith resources.
In order to sucessfully execute tests for stonith primitives the fence-agents-all package needs to be installed on the test node. Additionally, this code has been written such that debian based nodes should not attempt to execute the stonith tests.
Some helpful tips on running acceptance tests locally via vagrant. Not everyone has the time to sort out docker on their local machine.
Added more detail to the local vagrant testing section of the CONTRIBUTING.md guide. Specfically: * Ensuring the correct version of puppet is tested by the linter * Ensuring rubocop actually runs * Specifying puppet agent version for beaker Also added fixes to the cs_primitive acceptance tests as new behavior in the latest release of pcs (for CentOS 7.6?) now rejects IPaddr2 commands when multiple resources are declared with the same VIP.
|
The most recent commit is valid and passes all checks. Unfortunately the travis/docker timeout issue is still present so one of the builds failed due to this timeout. Could a maintainer repeat the failed job? |
bastelfreak
reviewed
Sep 21, 2019
bastelfreak
reviewed
Sep 21, 2019
manifests/init.pp
Outdated
| Optional[Array] $packageopts_corosync = $corosync::params::package_install_options, | ||
| Optional[Array] $packageopts_pacemaker = $corosync::params::package_install_options, | ||
| Optional[Array] $packageopts_crmsh = $corosync::params::package_install_options, | ||
| Optional[Array] $packageopts_pcs = $corosync::params::package_install_options, | ||
| Optional[Array] $packageopts_fence_agents = $corosync::params::package_install_options, |
There was a problem hiding this comment.
Suggested change
| Optional[Array] $packageopts_fence_agents = $corosync::params::package_install_options, | |
| Array[String[1]] $packageopts_fence_agen = $corosync::params::package_install_options, |
This should work as well. It allows an empty array. If data is provided, it has to be strings with at least one character.
|
Hi @pdemonaco, thanks for the awesome PR! Can you please take a look at the inline comments I made? I can also restart the tests afterwards if they fail again. |
Several of the package parameters and options specified on the parent corosync class could be improved slightly. This change incorporates these improvements.
|
Hi @bastelfreak in principal your suggestion makes sense but the way params.pp currently functions actually expects to set those packageopts parameters to undef. I've combined your suggestions with keeping those parameters optional. |
|
It's green \o/ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request (PR) description
In the pcs based pacemaker/corosync environment found on RedHat derivatives STONITH primitives are created an managed with a slightly different pcs command than standard primitives.
This pull request enhances the pcs provider for the cs_primitive type to appropriately handle STONITH primitives using the pcs stonith subcommand.
This Pull Request (PR) fixes the following issues
n/a