Puppet Strings Reference & Corosync Crypto #460
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updated each of the existing manifest files to generate a REFERENCE.md via puppet strings. Corosync Crypto Update Replaced 'secauth' in corosync.conf with the current crypto_hash and crypto_cipher parameters and updated the main class to take the appropriate arguments. Note that this change is not used on older versions of Ubuntu, RedHat/CentOS, and Debian which are still supported by this module but utilize Corosync 1.x instead of 2.x. Those OSs which are still supported continue to use the 'secauth' parameter and ignore the valuse of crypto_hash and crypto_cipher. Additionally, the documentation has been fleshed out to detail creating and deploying a secure key for Corosync's communication based on the corosync-keygen process. This also includes an updated to deploy the key file in a binary format as the application does not specify which key formats are supported.
|
@bastelfreak @towo As requested I've split the documentation changes out to a new branch. Unfortunately the crypto changes were already squashed into that original documentation commit and I'd rather not tease them apart, particularly since it's such a small change. Instead, I've attempted to address the corosync 1.x compatibility concern. Thoughts? Also, I didn't pull the change fixing Ruby 2.1.9 into this PR so it's going to fail on that in travis. |
alexjfisher
reviewed
Feb 28, 2019
alexjfisher
requested changes
Feb 28, 2019
Removing redundant declaration of the type on each puppet string line. Per the style guide here: https://puppet.com/docs/puppet/5.5/puppet_strings_style.html#parameters
pdemonaco
force-pushed
the
documentation-rework-for-puppet-strings
branch
from
93210db to
4c63964
Compare
@alexjfisher Should be all set |
|
@pdemonaco Thanks! |
alexjfisher
approved these changes
Mar 2, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request (PR) description
The following enhancements are incorporated in this pull request:
via puppet strings. Also tweaked the wording in some places to make things clearer.
Note that this PR is a partial split of changes currently in PR #458. Hopefully
separating these changes will make the features in that PR somewhat easier to work with.
This Pull Request (PR) fixes the following issues
Fixes #453