Do not explicitly request current environment #442
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bastelfreak
force-pushed
the
issue/403
branch
from
15cd058 to
cd0c783
Compare
|
Hi @towo, thanks for the PR and sorry for the slow response! I just rebased it against our master branch and will merge it afterwards. |
|
I just ran into this error myself and can confirm this PR fixes the problem! |
|
I would love to merge this, but I've no idea why it fails on debian 9 :(. Has anybody some more knowledge about pacemaker and can look into this? |
|
I could probably look into that later this week. |
landervdb
added a commit
to landervdb/puppet-corosync
that referenced
this pull request
Sep 24, 2018
This can lead to breakage under certain conditions that aren't fully clear. Puppet has been using the current environment in Module.find since 1.4.5[1], so it should not be necessary to actually define it. Fixes voxpupuli#403 [1] commit puppetlabs/puppet@b6fc631
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request (PR) description
Do not explicitly request current environment from
Puppet::Module.find.This can lead to breakage under certain conditions that aren't fully
clear. Puppet has been using the current environment in
Module.findsince 1.4.5[1], so it should not be necessary to actually define it.
The unit tests and an integration test for CentOS 7 ran through just fine.
This Pull Request (PR) fixes the following issues
Fixes #403
[1] commit puppetlabs/puppet@b6fc631