Replace PuppetX::Voxpupuli::Corosync::Provider:: by self.class #431
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can you take a look at the faiing spec tests? |
|
WIP: please don't merge |
alexjfisher
changed the title
|
Hi @actatux, what is the current state here? |
|
You can merge if the review is good. |
bastelfreak
force-pushed
the
replace_puppetx_by_self_class
branch
from
e750ca2 to
7149142
Compare
|
I rebased the branch again. Will merge it when it turn green. |
bastelfreak
changed the title
bastelfreak
removed
needs-feedback
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #376