Support timestamp and logfile config options #389
Conversation
antaflos
force-pushed
the
support_logfile_and_timestamp_options
branch
from
d4261f2 to
3b4119b
Compare
|
So apparently the acceptance test for Debian 8 fails as there seems to be a problem installing the openhpid package. This is definitely not related to my changes. |
|
Beaker tests are still failing because of the openhpid problem, unrelated to my changes. |
Add new class parameters "log_timestamp" and "log_file_name". log_timestamp is false by default; the "timestamp" option is only enabled in corosync.conf if log_timestamp => true. log_file_name is not set by default; the "logfile" option is only set in corosync.conf if log_file => true and log_file_name is an absolute path. If log_file_name is not an absolute path catalog compilation will fail. Includes spec tests and class parameter docs. This change is fully backwards compatible and does not change the contents of corosync.conf if the new parameters are left at their defaults.
antaflos
force-pushed
the
support_logfile_and_timestamp_options
branch
from
af6c2c4 to
cfa3f14
Compare
|
New month, new round of test errors that have nothing to do with my changes. Should I even bother checking back here again? Or are pull requests against this module a waste of everybody's time? |
|
Merged, Thanks and sorry! |
|
Nice, thank you! |
|
Hi @antaflos, sorry for the huge delay here. December till now was quite busy for us. Many people were on holidays and also we had a lot of work to do for the puppet 3 deprecation https://voxpupuli.org/blog/2017/01/11/migrating-to-puppet4/. However most of the work is done since the last weekend. We should be able to respond faster again to PRs. |
Add new class parameters "log_timestamp" and "log_file_name".
log_timestamp is false by default; the "timestamp" option is only
enabled in corosync.conf if log_timestamp => true.
log_file_name is not set by default; the "logfile" option is only set in
corosync.conf if log_file => true and log_file_name is an absolute path.
If log_file_name is not an absolute path catalog compilation will fail.
Includes spec tests and class parameter docs. This change is fully
backwards compatible and does not change the contents of corosync.conf
if the new parameters are left at their defaults.