-
-
Notifications
You must be signed in to change notification settings - Fork 161
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding rule property to crm location #310
Conversation
I've updated the branch with some (squashed) commits. If I'm not mistaken, the remaining failures are caused by the (currently unimplemented) pcs-provider on RedHat based systems. |
Thanks. I will not be able to review this until next week. |
@@ -17,6 +17,108 @@ | |||
# Decided to just go with relative. | |||
commands crm: 'crm' | |||
|
|||
mk_resource_methods | |||
|
|||
# The node2hash method maps resource locations from XML into hashes. The |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we move node2hash to cib_helper?
Is it possible to support lib/puppet/provider/cs_location/pcs.rb ? |
How can we mix this and #132? |
I am sorry but I am giving up on this one. I have a working implementation on Debian that does all I currently need. I don't have a RedHat machine for tests and fiddling with Beaker/Rubocop/... simply takes more time than I am willing to spend on this topic. If anyone is brave enough to work in this: feel free to use any of my code as you like. |
Thanks. Will do in #356 |
Please check the following items before submitting a PR -- thank you!
Note that this project is released with a Contributor Code of Conduct.
By participating in this project you agree to abide by its terms.
Contributor Code of Conduct.
closed once this PR gets merged, i.e:
Closes #1554
in the body of a committries to address multiple issues. Though we prefer one PR per feature/fix,
sometimes that's not feasible. In that case ensure that a single feature/fix
and associated tests and documentation is bundled up in one commit
Optional, but extra points:
reintroduced
There is no real progress at PR #132 currently. I am submitting this PR as a different implementation for the
crm
provider. My implementation adds the following enhancements:rule
parameter has been renamed torules
as it will take an array with multiple rules.score
for a direct scorescore-attribute
to use the attribute value as scoreexpression
containing an array of expressions to evaluate. Each array element is also a hash containing theattribute
,operation
and possibly thevalue
of the expression.boolean-op
which can beand
(default) oror
to indicate how the expressions are joinedThe README has been updated to show some of the possibilities.
I have included an updated version of the acceptance test written by @GiooDev but unfortunately I have no environment to run acceptance tests, so this might be an issue...