Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clone names can't be overridden #149

Closed
fghaas opened this issue Jul 14, 2015 · 9 comments
Closed

Clone names can't be overridden #149

fghaas opened this issue Jul 14, 2015 · 9 comments
Milestone
5.x

Comments

@fghaas
Copy link
Contributor

fghaas commented Jul 14, 2015

https://github.com/puppet-community/puppet-corosync/blob/master/lib/puppet/provider/cs_clone/pcs.rb#L59 sets the clone's CIB ID to <primitive>-clone, which is an arbitrary naming convention. The CIB ID should simply honor the cs_clone resource's namevar, name.
fghaas added a commit to fghaas/puppet-iscsi-rbd-ha that referenced this issue Jul 14, 2015
@fghaas
Work around hardcoded clone resource ID
7af6823 
Cloned resources currently *must* be named "<primitive id>-clone".

See voxpupuli/puppet-corosync#149 for
upstream bug report.
fghaas added a commit to fghaas/puppet-iscsi-rbd-ha that referenced this issue Jul 14, 2015
@fghaas
Work around hardcoded clone resource ID
0d4a966 
Cloned resources currently *must* be named "<primitive id>-clone".

See voxpupuli/puppet-corosync#149 for
upstream bug report.
fghaas added a commit to fghaas/puppet-iscsi-rbd-ha that referenced this issue Jul 14, 2015
@fghaas
Work around hardcoded clone resource ID
d917e15 
Cloned resources currently *must* be named "<primitive id>-clone".

See voxpupuli/puppet-corosync#149 for
upstream bug report.
@igalic
Copy link
Contributor

igalic commented Oct 14, 2015

@fghaas are you interested in providing your patch as pull-request?

i absolutely agree that create MUST NOT change name (or the namevar, in general)

@bogdando
Copy link
Contributor

bogdando commented Nov 2, 2015

@fghaas do you suggest to not add the "-clone" postfix?

@fghaas
Copy link
Contributor Author

fghaas commented Nov 2, 2015

@bogdando I am suggesting to not override the user's choice for the namevar at all.

@bogdando
Copy link
Contributor

bogdando commented Nov 3, 2015

That makes sense I believe

@jyaworski
Copy link
Member

Is this related to #176?

@roidelapluie
Copy link
Member

That is more complex AFAIK because the clone is different than the primtive

@roidelapluie roidelapluie modified the milestone: 5.x Sep 14, 2016
roidelapluie added a commit to roidelapluie/puppet-corosync that referenced this issue Sep 15, 2016
@roidelapluie
Improve cs_clone
a85a427 
- Stop cs_clone before removing (crm provider)
- Use resource name as clone id (pcs provider) - closes voxpupuli#149
- Add acceptance tests and improve unit tests

Signed-off-by: Julien Pivotto <[email protected]>
roidelapluie added a commit to roidelapluie/puppet-corosync that referenced this issue Sep 15, 2016
@roidelapluie
Improve cs_clone
90ce0f2 
- Stop cs_clone before removing (crm provider)
- Use resource name as clone id (pcs provider) - closes voxpupuli#149
- Add acceptance tests and improve unit tests

Signed-off-by: Julien Pivotto <[email protected]>
roidelapluie added a commit to roidelapluie/puppet-corosync that referenced this issue Sep 15, 2016
@roidelapluie
Improve cs_clone
d13bad1 
- Stop cs_clone before removing (crm provider)
- Use resource name as clone id (pcs provider) - closes voxpupuli#149
- Add acceptance tests and improve unit tests

Signed-off-by: Julien Pivotto <[email protected]>
roidelapluie added a commit to roidelapluie/puppet-corosync that referenced this issue Sep 15, 2016
@roidelapluie
Improve cs_clone
1cc7cee 
- Stop cs_clone before removing (crm provider)
- Use resource name as clone id (pcs provider) - closes voxpupuli#149
- Add acceptance tests and improve unit tests

Signed-off-by: Julien Pivotto <[email protected]>
roidelapluie added a commit to roidelapluie/puppet-corosync that referenced this issue Sep 15, 2016
@roidelapluie
Improve cs_clone
9706d20 
- Stop cs_clone before removing (crm provider)
- Use resource name as clone id (pcs provider) - closes voxpupuli#149
- Add acceptance tests and improve unit tests

Signed-off-by: Julien Pivotto <[email protected]>
roidelapluie added a commit to roidelapluie/puppet-corosync that referenced this issue Sep 15, 2016
@roidelapluie
Improve cs_clone
bee96d2 
- Stop cs_clone before removing (crm provider)
- Use resource name as clone id (pcs provider) - closes voxpupuli#149
- Add acceptance tests and improve unit tests

Signed-off-by: Julien Pivotto <[email protected]>
roidelapluie added a commit to roidelapluie/puppet-corosync that referenced this issue Sep 15, 2016
@roidelapluie
Improve cs_clone
e3a9a58 
- Stop cs_clone before removing (crm provider)
- Use resource name as clone id (pcs provider) - closes voxpupuli#149
- Add acceptance tests and improve unit tests

Signed-off-by: Julien Pivotto <[email protected]>
@roidelapluie
Copy link
Member

@fghaas That was a nice one as PCS does not support arbitrary id's for clones.

Here is the trick:
0f20634#diff-8a13e73d1c1985ded0fc337a4f685ab9R20

@fghaas
Copy link
Contributor Author

fghaas commented Sep 15, 2016

@roidelapluie Cool, thanks!

@roidelapluie
Copy link
Member

I plan to release a 5.0.0-beta 3 within the next days

@btravouillon btravouillon mentioned this issue Oct 23, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
5.x
Development

No branches or pull requests
5 participants
@roidelapluie @jyaworski @igalic @fghaas @bogdando