Install collectd-mcelog package on RedHat #962
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kenyon
requested changes
Nov 24, 2020
There was a problem hiding this comment.
This is missing $_manage_package = pick($manage_package, $collectd::manage_package) and $package_install_options should be a parameter. See https://github.com/voxpupuli/puppet-collectd/blob/f9f2e7d37e2d0d5669acc1908f764eb62d0ff792/manifests/plugin/apache.pp or https://github.com/voxpupuli/puppet-collectd/blob/f9f2e7d37e2d0d5669acc1908f764eb62d0ff792/manifests/plugin/lvm.pp for examples. Also https://github.com/voxpupuli/puppet-collectd/blob/master/spec/classes/collectd_plugin_mcelog_spec.rb should be updated.
|
@kenyon Thanks for the review! I added |
kenyon
requested changes
Dec 17, 2020
kenyon
approved these changes
Dec 17, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request (PR) description
Similar to
collectd-sensors, redhat systems needcollectd-mcelogpackage to be installed.This Pull Request (PR) fixes the following issues
Fixes issue when collectd fails with
plugin_load: Could not find plugin "mcelog" in /usr/lib64/collectd