Add CentOS 8 support #917
Merged
Add CentOS 8 support #917
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think after this it makes sense to add a |
traylenator
force-pushed
the
eight
branch
3 times, most recently
from
f8632dd to
944a463
Compare
|
Dear @traylenator, thanks for the PR! This is pccibot, your friendly Vox Pupuli GitHub Bot. I noticed that your pull request contains merge conflict. Can you please rebase? You can find my sourcecode at voxpupuli/vox-pupuli-tasks |
1 similar comment
|
Dear @traylenator, thanks for the PR! This is pccibot, your friendly Vox Pupuli GitHub Bot. I noticed that your pull request contains merge conflict. Can you please rebase? You can find my sourcecode at voxpupuli/vox-pupuli-tasks |
traylenator
force-pushed
the
eight
branch
2 times, most recently
from
6f6faf6 to
358b8fb
Compare
The main differences for CentOS 8 are: * There is now a new collectd-utils package containing collectdctl * collectd-python is now a seperate sub package * python is python3. * pip command is now pip3 * The rabbitmq plugin no longer works due to lack of python3 support The python_dir fact will fall back to `/usr/libexec/platform-python` if `python3` does not exist on the path. This is the python that collectd is built against and significantly requires. Note that setting `collectd::ci_package_repo` true will currently result in yum being configured with a non existant repo since https://pkg.ci.collectd.org/rpm/ does not exist for 8. collectd/collectd-ci#35
bastelfreak
approved these changes
Mar 9, 2020
|
@traylenator thanks for the awesome work! Is this still WIP? |
|
One more feature to add I'll make a release hopefully. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request (PR) description
Add CentOS 8 support
The main differences for CentOS 8 are:
The
python_dirfact will fall back to/usr/libexec/platform-pythonif
python3does not exist on the path. This is the pythonthat collectd uses and significantly all that collectd-python requires.
Note that setting
collectd::ci_package_repotrue will currentlyresult in yum being configured with a non existant repo since
https://pkg.ci.collectd.org/rpm/ does not exist
for 8. request