turbotstat: Add LogicalCoreNames option #815
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
templates/plugin/turbostat.conf.epp
Outdated
| @@ -0,0 +1,25 @@ | |||
| <Plugin turbostat> | |||
| <% if $::collectd::plugin::turbostat::core_c_states { -%> | |||
There was a problem hiding this comment.
Drop the $:: - it's not needed
There was a problem hiding this comment.
I have dropped the useless '::', but the '$' is required.
juniorsysadmin
approved these changes
Jun 6, 2018
Since collectd-5.7, we can configure the name convention for core names. This change adds this.
sileht
force-pushed
the
sileht/turbotstat
branch
from
261d56d to
d5c1fc1
Compare
bastelfreak
reviewed
Jun 13, 2018
| @@ -7,11 +7,12 @@ | |||
| Optional[Boolean] $digital_temperature_sensor = undef, | |||
| Optional[Integer] $tcc_activation_temp = undef, | |||
| Optional[Integer] $running_average_power_limit = undef, | |||
| Optional[Boolean] $logical_core_names = undef, | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
turbotstat: Add LogicalCoreNames option
Since collectd-5.7, we can configure the name convention for core names.
This change adds this.