plugin: add battery plugin #800
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bastelfreak
reviewed
May 30, 2018
manifests/plugin/battery.pp
Outdated
| @@ -0,0 +1,17 @@ | |||
| # https://collectd.org/wiki/index.php/Plugin:Uptime | |||
| class collectd::plugin::battery ( | |||
| $ensure = 'present', | |||
There was a problem hiding this comment.
please add a datatype for $ensure as well.
bastelfreak
reviewed
May 30, 2018
| </Plugin> | ||
|
|
||
| EOS | ||
|
|
There was a problem hiding this comment.
please also add a is_expected.to compile.with_all_deps test
bastelfreak
reviewed
May 30, 2018
templates/plugin/battery.conf.erb
Outdated
| @@ -0,0 +1,11 @@ | |||
| <Plugin "battery"> | |||
There was a problem hiding this comment.
for new templates we agreed on epp only: https://voxpupuli.org/docs/#reviewing-a-module-pr
Can you please convert this to epp?
bastelfreak
reviewed
May 30, 2018
manifests/plugin/battery.pp
Outdated
| class collectd::plugin::battery ( | ||
| $ensure = 'present', | ||
| $interval = undef, | ||
| Optional[Boolean] $values_percentage = undef, |
There was a problem hiding this comment.
can we instead default to true or false and don't mark it as optional?
bastelfreak
added
enhancement
this change adds the battery plugin
bastelfreak
force-pushed
the
sileht/battery
branch
from
7a98167 to
5f741b6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this change adds the battery plugin